Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Egaxhaj figure/adr 038 plugin system with release pio v0.45.x #64

Conversation

egaxhaj
Copy link

@egaxhaj egaxhaj commented Mar 2, 2022

For cosmos#10096

On top of cosmos#10639

This is an implementation of ADR-038 using a plugin system for state listening. In addition to the file plugin two plugins have been added: kafka and trace (stdout) as examples. This implementation includes a few changes from cosmos#10639:

Description

Closes: #540


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@egaxhaj egaxhaj self-assigned this Mar 2, 2022
@egaxhaj
Copy link
Author

egaxhaj commented Apr 13, 2022

Closing PR. Work was merged in #95

@egaxhaj egaxhaj closed this Apr 13, 2022
@egaxhaj egaxhaj deleted the egaxhaj-figure/adr_038_plugin_system_with_release_pio_v0.45.x branch April 13, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants