forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Egaxhaj figure/adr 038 plugin system with release pio v0.45.x #64
Closed
egaxhaj
wants to merge
41
commits into
release-pio/v0.45.x
from
egaxhaj-figure/adr_038_plugin_system_with_release_pio_v0.45.x
Closed
Egaxhaj figure/adr 038 plugin system with release pio v0.45.x #64
egaxhaj
wants to merge
41
commits into
release-pio/v0.45.x
from
egaxhaj-figure/adr_038_plugin_system_with_release_pio_v0.45.x
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing PR. Work was merged in #95 |
egaxhaj
deleted the
egaxhaj-figure/adr_038_plugin_system_with_release_pio_v0.45.x
branch
April 13, 2022 18:07
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cosmos#10096
On top of cosmos#10639
This is an implementation of ADR-038 using a plugin system for state listening. In addition to the
file
plugin two plugins have been added:kafka
andtrace
(stdout) as examples. This implementation includes a few changes from cosmos#10639:opt-in
approach to enable plugins vs a list of disabled plugins (as discussed in feat: ADR-038 plugin system cosmos/cosmos-sdk#10639 (comment)).cosmos-sdk/plugin/example_config.toml
Line 11 in beafe76
ack
channel as this proved to be fragile during implementation (required increasing timeout to undesired levels in abci.Commit()). Instead, the application will halt based on the property value set forplugins.streaming.<plugin-name>.halt_app_on_delivery_error = true|false
when an error is return byListenBeginBlock
,ListenEndBlock
orListenDeliverTx
.cosmos-sdk/baseapp/streaming.go
Line 23 in 5642344
Description
Closes: #540
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change